[PATCH] D136361: [AArch64][SME] Disable GlobalISel/FastISel for SME functions.

Mon Oct 31 06:55:09 PDT 2022

david-arm added a comment.

Thanks for adding the new tests @sdesmalen! I just had a question about `@za_new_caller_to_za_shared_callee` - perhaps I'm missing something obvious and this is my :face_palm moment!

================
Comment at: llvm/test/CodeGen/AArch64/sme-disable-gisel-fisel.ll:180
+
+define void @locally_streaming_caller_streaminhg_callee_ptr(ptr %p) nounwind noinline optnone "aarch64_pstate_sm_body" {
+; CHECK-COMMON-LABEL: locally_streaming_caller_streaminhg_callee_ptr:
----------------
nit: s/streaminhg/streaming/

================
Comment at: llvm/test/CodeGen/AArch64/sme-disable-gisel-fisel.ll:251
+; CHECK-FISEL-NEXT:    bl za_shared_callee
+; CHECK-FISEL-NEXT:    smstart za
+; CHECK-FISEL-NEXT:    mrs x8, TPIDR2_EL0
----------------
Not sure if this is caused by your patch or not, but it looks a bit odd. Perhaps I'm missing something, but it seems to be treating `za_shared_callee` as a private-ZA function and setting up a lazy-save + restore. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136361/new/

https://reviews.llvm.org/D136361