[PATCH] D134195: [PowerPC] XCOFF exception section support on the integrated assembler path

Mon Oct 31 06:26:50 PDT 2022

tschuett added a comment.

In D134195#3896249 <https://reviews.llvm.org/D134195#3896249>, @pscoro wrote:

> In D134195#3895476 <https://reviews.llvm.org/D134195#3895476>, @tschuett wrote:
>
>> In D134195#3895297 <https://reviews.llvm.org/D134195#3895297>, @pscoro wrote:
>>
>>> Replacing DenseMap usage with std::map to ensure a determinable order of exception entries
>>
>> Could you please check whether you find something for your use case:
>> https://llvm.org/docs/ProgrammersManual.html#picking-the-right-data-structure-for-a-task
>>
>> `std::map` is frowned upon in LLVM. It is very heap heavy.
>
> I need a map data structure with a determinable order, I was looking at that page earlier when I settled on `std::map`. The only other option I saw was MapVector:
>
>> MapVector<KeyT,ValueT> provides a subset of the DenseMap interface. The main difference is that the iteration order is guaranteed to be the insertion order, making it an easy (but somewhat expensive) solution for non-deterministic iteration over maps of pointers.
>
> I chose std::map over this because I thought MapVector would be too expensive, would you know if MapVector would be less expensive and preferable to std::map here?

Unfortunately no.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134195/new/

https://reviews.llvm.org/D134195