[PATCH] D136937: [GlobalISel] Compute debug location when merging stores more accurately

Anton Sidorenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 31 06:13:53 PDT 2022


asi-sc added a comment.

In D136937#3892278 <https://reviews.llvm.org/D136937#3892278>, @aemerson wrote:

> Thanks for fixing this, could you add a small test as well?

I added a test, but uploaded only the diff to make a stress on the change. In the test there are 4 store instructions with equal line (=9), but different column number.  First two stores have column number = 1, third and fourth stores have column number = 4. That's why when we merge locations incorrectly by using only two last stores, we have `column: 4` in the merged store too. However, when merging locations for all four stores, we cannot find one common column number, so we dropping this information at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136937/new/

https://reviews.llvm.org/D136937



More information about the llvm-commits mailing list