[PATCH] D136986: X86: Implement null target streamer
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 31 03:43:57 PDT 2022
RKSimon added inline comments.
================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86TargetStreamer.h:41
+ return new X86TargetStreamer(S);
+}
+
----------------
arsenm wrote:
> RKSimon wrote:
> > Why not create a X86TargetNullStreamer class and keep X86TargetStreamer as it is?
> That's a lot of extra boilerplate to do nothing
OK - I see WebAssemblyTargetNullStreamer does override but I don't think its vital.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136986/new/
https://reviews.llvm.org/D136986
More information about the llvm-commits
mailing list