[PATCH] D136525: [M68k] Add codegen pattern for atomic load / store
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 31 03:40:34 PDT 2022
RKSimon added inline comments.
================
Comment at: llvm/lib/Target/M68k/M68kInstrAtomics.td:27
+
+multiclass AtomicPatterns {
+ foreach size = [8, 16, 32] in {
----------------
0x59616e wrote:
> myhsu wrote:
> > Why do we need to wrap these patterns with multiclass?
> Yeah that's verbose. I didn't think this through.
Probably the best way to make this 020+ only is to wrap the patterns, something like:
```
let Predicates = [FeatureISA20] {
foreach size = [8, 16, 32] in {
....
}
}
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136525/new/
https://reviews.llvm.org/D136525
More information about the llvm-commits
mailing list