[PATCH] D136672: [ExpandMemCmp][AArch64] Add a new option PreferCmpToExpand in inMemCmpExpansionOptions and enable on AArch64

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

>From the looks of the tests the AND should be optimized out. My guess would be that we don't revisit the setcc after the and have been simplified though. It might work better if it was run during lowering.

> For now, what I want to discuss is: Do we need this patch?

I think, at the moment, we are heading towards ISel folds to turn the the eor patterns into ccmp. If we don't think that method will work (or is too complicated), then this patch would be useful. But it should be more general to fix it in ISel, as it should capture more cases than just bcmp.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136672/new/

https://reviews.llvm.org/D136672