[PATCH] D137055: [MachinePipeliner] Remove unused LoopInfo data fields
Afanasyev Ivan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Oct 30 23:44:40 PDT 2022
ivafanas created this revision.
ivafanas added reviewers: DavidPendy, jsji, kparzysz.
Herald added a subscriber: hiraditya.
Herald added a project: All.
ivafanas requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
`LoopInductionVar` and `LoopCompare` data members of `MachinePipeliner::LoopInfo` struct seems to be unused asf ar as nobody reads their value. Should be removed.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D137055
Files:
llvm/include/llvm/CodeGen/MachinePipeliner.h
llvm/lib/CodeGen/MachinePipeliner.cpp
Index: llvm/lib/CodeGen/MachinePipeliner.cpp
===================================================================
--- llvm/lib/CodeGen/MachinePipeliner.cpp
+++ llvm/lib/CodeGen/MachinePipeliner.cpp
@@ -368,8 +368,6 @@
return false;
}
- LI.LoopInductionVar = nullptr;
- LI.LoopCompare = nullptr;
LI.LoopPipelinerInfo = TII->analyzeLoopForPipelining(L.getTopBlock());
if (!LI.LoopPipelinerInfo) {
LLVM_DEBUG(dbgs() << "Unable to analyzeLoop, can NOT pipeline Loop\n");
Index: llvm/include/llvm/CodeGen/MachinePipeliner.h
===================================================================
--- llvm/include/llvm/CodeGen/MachinePipeliner.h
+++ llvm/include/llvm/CodeGen/MachinePipeliner.h
@@ -83,8 +83,6 @@
MachineBasicBlock *TBB = nullptr;
MachineBasicBlock *FBB = nullptr;
SmallVector<MachineOperand, 4> BrCond;
- MachineInstr *LoopInductionVar = nullptr;
- MachineInstr *LoopCompare = nullptr;
std::unique_ptr<TargetInstrInfo::PipelinerLoopInfo> LoopPipelinerInfo =
nullptr;
};
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137055.471904.patch
Type: text/x-patch
Size: 1037 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221031/ac565638/attachment.bin>
More information about the llvm-commits
mailing list