[llvm] 5008762 - [lit][NFC] not check stdout in googletest-timeout.py

Yuanfang Chen via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 30 23:20:57 PDT 2022


Author: Yuanfang Chen
Date: 2022-10-30T23:17:50-07:00
New Revision: 500876226c606cd2d205557a842bd0a3fa9231ea

URL: https://github.com/llvm/llvm-project/commit/500876226c606cd2d205557a842bd0a3fa9231ea
DIFF: https://github.com/llvm/llvm-project/commit/500876226c606cd2d205557a842bd0a3fa9231ea.diff

LOG: [lit][NFC] not check stdout in googletest-timeout.py

This is flicky for buildbots (for example, https://lab.llvm.org/buildbot/#/builders/188/builds/21560)
because of the short timeout. The test coverage is not reduced because
the stdout check is performed in other googtest-* unit tests.

Added: 
    

Modified: 
    llvm/utils/lit/tests/Inputs/googletest-timeout/DummySubDir/OneTest.py
    llvm/utils/lit/tests/googletest-timeout.py

Removed: 
    


################################################################################
diff  --git a/llvm/utils/lit/tests/Inputs/googletest-timeout/DummySubDir/OneTest.py b/llvm/utils/lit/tests/Inputs/googletest-timeout/DummySubDir/OneTest.py
index 6a698938dc722..73f659ee0b43f 100644
--- a/llvm/utils/lit/tests/Inputs/googletest-timeout/DummySubDir/OneTest.py
+++ b/llvm/utils/lit/tests/Inputs/googletest-timeout/DummySubDir/OneTest.py
@@ -54,8 +54,6 @@
             f.write(output)
         exit_code = 0
     elif test_name == 'InfiniteLoopSubTest':
-        print('[ RUN      ] T.InfiniteLoopSubTest', flush=True)
-        print('some in progess output', file=sys.stderr, flush=True)
         while True:
             pass
     else:

diff  --git a/llvm/utils/lit/tests/googletest-timeout.py b/llvm/utils/lit/tests/googletest-timeout.py
index a32759f17a030..a17d3a5b9cb6b 100644
--- a/llvm/utils/lit/tests/googletest-timeout.py
+++ b/llvm/utils/lit/tests/googletest-timeout.py
@@ -26,8 +26,6 @@
 # CHECK-INF-NEXT: GTEST_OUTPUT=json:{{[^[:space:]]*}} GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=2 GTEST_SHARD_INDEX=0 {{.*}}[[FILE]]
 # CHECK-INF-NEXT: --
 # CHECK-INF-EMPTY:
-# CHECK-INF-NEXT: [ RUN ] T.InfiniteLoopSubTest
-# CHECK-INF-NEXT: some in progess output
 # CHECK-INF-EMPTY:
 # CHECK-INF-NEXT: --
 # CHECK-INF-NEXT: exit:


        


More information about the llvm-commits mailing list