[PATCH] D136822: [InstCombine] Allow memcpys from constant memory to readonly noalias parameters to be elided.

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

Can you please precommit your test cases (they look fine) and split off the volatile change into a separate patch? I agree that this was a bug, but it's not directly related to the change here.



================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp:131
+      if (MI->isVolatile())
+        return false;
+
----------------
There is another volatile check above, just drop the operand check there?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136822/new/

https://reviews.llvm.org/D136822