[llvm] 323fb62 - [Hexagon] Report changes in HvxIdioms pass

Krzysztof Parzyszek via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 29 11:32:51 PDT 2022


Author: Krzysztof Parzyszek
Date: 2022-10-29T11:32:28-07:00
New Revision: 323fb627a594d4c77f6220507d5a663579e02cfb

URL: https://github.com/llvm/llvm-project/commit/323fb627a594d4c77f6220507d5a663579e02cfb
DIFF: https://github.com/llvm/llvm-project/commit/323fb627a594d4c77f6220507d5a663579e02cfb.diff

LOG: [Hexagon] Report changes in HvxIdioms pass

It can produce some dead code, which is harmless in the end, but breaks
expensive checks when unreported. This should be fixed eventually, but
it's a low priority.

Added: 
    

Modified: 
    llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp b/llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp
index f3913a9adefd..6c116b569337 100644
--- a/llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp
+++ b/llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp
@@ -1405,6 +1405,8 @@ auto HvxIdioms::run() -> bool {
     for (auto It = B.rbegin(); It != B.rend(); ++It) {
       if (auto Fxm = matchFxpMul(*It)) {
         Value *New = processFxpMul(*It, *Fxm);
+        // Always report "changed" for now.
+        Changed = true;
         if (!New)
           continue;
         bool StartOver = !isa<Instruction>(New);


        


More information about the llvm-commits mailing list