[PATCH] D136496: [bazel] Make labels to third-party dependencies explicit

Aaron Siddhartha Mondal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 29 09:25:38 PDT 2022


aaronmondal added a comment.

There is also the situation where `@llvm-project-overlay` actually refers to the top level directory in the llvm repo. This is the case if we import the module in an external module via `bazel_dep(name="@llvm-project-overlay", version="16.0.0-bcr.0")`. If we were to disallow builds from within the `utils/bazel` repo, this may make it possible to keep the labels relative,

This seems like a bad idea to me though, since it would mean that it would be impossible to build and test the bazel overlay from within `utils/bazel`. This would add additional complexity to future CI runs that build/test the bzlmod build.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136496/new/

https://reviews.llvm.org/D136496



More information about the llvm-commits mailing list