[PATCH] D136986: X86: Implement null target streamer

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 29 09:11:49 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86TargetStreamer.h:41
+  return new X86TargetStreamer(S);
+}
+
----------------
RKSimon wrote:
> Why not create a X86TargetNullStreamer class and keep X86TargetStreamer as it is?
That's a lot of extra boilerplate to do nothing


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136986/new/

https://reviews.llvm.org/D136986



More information about the llvm-commits mailing list