[PATCH] D136912: [AArch64] precommit tests and code format for D136623, NFC

[Allen zhong via Phabricator via llvm-commits]

Allen marked an inline comment as done.
Allen added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:775
     // to "(A op C) op' (B op C)" results in simplifications.
     Value *A = Op0->getOperand(0), *B = Op0->getOperand(1), *C = RHS;
     Instruction::BinaryOps InnerOpcode = Op0->getOpcode(); // op'
----------------
spatel wrote:
> The brackets that you are proposing to remove are likely protecting against shadow variable declaration compile-time warnings.
> 
> Please remove this diff from this patch. 
> 
> I suggest one of the following to improve this code (as a separate commit):
> 1. Rename the set of variables above with unique names (and adjust the code comments to match).
> 2. Rename the set of variables here with unique names (and adjust the code comments to match).
> 3. Create a helper function for the Factorization set of folds, so there is no confusion.
Thanks for suggestion, addressed in https://reviews.llvm.org/D137019


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136912/new/

https://reviews.llvm.org/D136912