[PATCH] D127831: BasicBlockUtils: Add a new way for CreateControlFlowHub()
Sameer Sahasrabuddhe via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 28 22:33:29 PDT 2022
sameerds added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/BasicBlockUtils.cpp:1807
+ const BBSetVector &Outgoing, const StringRef Prefix,
+ Optional<unsigned> MaxControlFlowBooleans) {
+ BBPredicates GuardPredicates;
----------------
This is more curiosity than comment ... what is the advantage of using an Optional here? How does it compare to just using ~0 as the (maximum) default value?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127831/new/
https://reviews.llvm.org/D127831
More information about the llvm-commits
mailing list