[PATCH] D136614: llvm-reduce: Report file opening errors

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 15:47:25 PDT 2022


aeubanks added inline comments.


================
Comment at: llvm/tools/llvm-reduce/deltas/Delta.cpp:85
+
     if (OutStream.has_error()) {
+      errs() << "Error emitting bitcode to file '" << CurrentFilepath
----------------
I think the intention of the original code was also to check if the writing caused any problems. So we should check before and after? And ditto below in the textual IR. Probably we should factor out the check into a helper function/lambda


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136614/new/

https://reviews.llvm.org/D136614



More information about the llvm-commits mailing list