[PATCH] D136983: AMDGPU: Register a null MC streamer for -emit-codegen-only

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: StephenFan.

LGTM with some nits



================
Comment at: clang/test/Misc/backend-resource-limit-diagnostics.hip:1
-// RUN: not %clang_cc1 -triple amdgcn-amd-amdhsa -target-cpu gfx906 -x hip -fcuda-is-device -S -o /dev/null %s 2>&1 | FileCheck %s
-// FIXME: Use -emit-codegen-only
+// RUN: not %clang_cc1 -triple amdgcn-amd-amdhsa -target-cpu gfx906 -x hip -fcuda-is-device -emit-codegen-only %s 2>&1 | FileCheck %s
 
----------------
The layering is strange. This patch ideally should land before the clang patch.


================
Comment at: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.h:66
   /// \returns True on success, false on failure.
-  virtual bool EmitISAVersion() = 0;
+  virtual bool EmitISAVersion() {return true;}
 
----------------
`{ return true; }`

Use clang-format


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136983/new/

https://reviews.llvm.org/D136983