[PATCH] D136954: DiagnosticInfo: Report function location for resource limits

Fri Oct 28 14:07:08 PDT 2022

arsenm added inline comments.

================
Comment at: clang/test/Misc/backend-resource-limit-diagnostics.hip:1
+// RUN: not %clang_cc1 -debug-info-kind=standalone -triple amdgcn-amd-amdhsa -target-cpu gfx906 -x hip -fcuda-is-device -S -o /dev/null < %s 2>&1 | FileCheck %s
+// FIXME: Use -emit-codegen-only
----------------
MaskRay wrote:
> MaskRay wrote:
> > paulkirth wrote:
> > > Does this need  `// REQUIRES: amdgpu-registered-target`, like the test in `backend-resourse-limit-diagnostics.cl`?
> > `-emit-codegen-only` is preferred to `-S -o /dev/null`
> Ignore me. I assume that the object MC backend isn't available. `-S -o /dev/null` looks fine.
Fixed this in D136983, The null streamer is broken in 19/24 in tree targets

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136954/new/

https://reviews.llvm.org/D136954