[PATCH] D136777: llvm::zip should not require assignment operator

Fri Oct 28 13:44:17 PDT 2022

dblaikie added a comment.

In D136777#3890394 <https://reviews.llvm.org/D136777#3890394>, @mehdi_amini wrote:

> In D136777#3890280 <https://reviews.llvm.org/D136777#3890280>, @dblaikie wrote:
>
>> Yep - might be worth checking the ElementsAttrIterator to ensure it at least meets the newer iterator concepts at least.
>
> On top of the patch here, we're also adding copy construction and copy assignment on ElementsAttrIterator by the way, it seems like reasonable addition and it seems like it was an oversight to not have it there (this particular iterator isn't that "fat": two bools and two pointers).

Awesome - thanks for the details!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136777/new/

https://reviews.llvm.org/D136777