[PATCH] D134064: [InstCombine] Baseline tests for folding ((x?1:4)&(y?1:4))==0 to x^y

[Marc Auberer via Phabricator via llvm-commits]

marcauberer added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/select_and_icmpeq.ll:151
+;
+  %z = add i6 1, 2
+  %s1 = select i1 %x, i6 %z, i6 5
----------------
spatel wrote:
> This (and similar other tests) doesn't provide the coverage that you were hoping for. 
> This will be constant-folded before we ever reach the transform that we're hoping to unit-test.
> That's why the test is already completely reduced to "false". :)
Okay, shall I remove them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134064/new/

https://reviews.llvm.org/D134064