[PATCH] D136077: [AArch64]SME2 Outer Product and Accumulate instructions

Fri Oct 28 09:55:52 PDT 2022

CarolineConcatto marked an inline comment as done.
CarolineConcatto added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64SMEInstrInfo.td:557
+
+defm SMOPA_TPPZZ : sme2_int_mopx_tile<"smopa", 0b00>;
+defm SMOPS_TPPZZ : sme2_int_mopx_tile<"smops", 0b01>;
----------------
paulwalker-arm wrote:
> CarolineConcatto wrote:
> > paulwalker-arm wrote:
> > > The equivalent SME1 instruction is `SMOPA_MPPZZ_S` so I'd expect this to be named similar but much like with the DOT instructions you'll need to rename the original to reflect the difference between 4way and 2way.  So the original becomes `SMOPA_MPPZZ_BtoS and SMOPA_MPPZZ_HtoD` and this new one becomes `SMOPA_MPPZZ_HtoS`.  Do you agree?
> > I had changed for SME1, but these instructions name are in use in AArch64ISelLowering.
> > So I did not changed for sme1, but did for sme2.
> > TBH I don't know what is more consistent, changing or not changing the names for sme2.
> We should change the old names to be consistent.  It doesn't matter that they are used by AArch64ISelLowering because it's just a textual change. It's not that the old names were wrong when originally added, but based on these new SME2 instructions the old names will lead to confusion, hence the new `_HtoS` style for such things.
> 
> With all that said, this assembler work is more important so feel free to defer that refactoring until the assembler support is complete.
Thank you Paul, I will create a to do for that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136077/new/

https://reviews.llvm.org/D136077