[PATCH] D135780: [IR] Switch everything to use memory attribute

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 07:03:41 PDT 2022


nhaehnle added a comment.

Thank you for the additional explanation for not splitting up. This *is* likely to cause a little annoyance for downstreams, but your reasoning makes sense to me and so I'm not going to stand in the way :)

To be clear, you can count my earlier comment like an "Acked-by" and partial review. Combined with @jdoerfert's look earlier, I'd be satisfied for the LLVM parts. I can't speak for Clang, though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135780/new/

https://reviews.llvm.org/D135780



More information about the llvm-commits mailing list