[PATCH] D136713: [SDAG] avoid vector extract/insert around binop

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 28 07:00:13 PDT 2022


thakis added a comment.

In D136713#3890855 <https://reviews.llvm.org/D136713#3890855>, @dyung wrote:

> @spatel, after this commit, we started seeing an assertion failure being hit in two of our internal tests. I have filed this as issue #58661, can you take a look?

Thanks for filing this! We hit the same problem, and the fix fixes it for us too.

It would've been nice if this had been reverted once the problem was found – then the probably would've gone away 7 hours earlier and I wouldn't have had to spend time to track it down as well :) If things take a while to fix, I think it's good to revert first and then fix asynchronously, to save the duplicate work of several people tracking down their compile failures to the same commit, only to discover that the problem is already known.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136713/new/

https://reviews.llvm.org/D136713



More information about the llvm-commits mailing list