[PATCH] D136946: [AMDGPU] Enable `update/mov.dpp` selection with `+dpp,+gfx8-insts`

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

> Though, the change in `pseudoToMCOpcode` will still need to be DPP-specific because if I only check for GFX8-insts, it creates a mess (about 90 tests failures + various crashes). It seems like it needs to return -1 in some cases so I did a very targeted fix there (which I don't really like, if there's a better option I'd love to do something else really)

I think most of those extra cases in `pseudoToMCOpcode` should be conditional on `MCOp == (uint16_t)-1`, i.e. only try them if we have so far failed to find an MC opcode. Does that help?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136946/new/

https://reviews.llvm.org/D136946