[PATCH] D136939: [X86] Use default attributes for intrinsics

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added a comment.

> I just want to ensure we're not going to have a problem with a few cases (e.g. the round intrinsics which can be dependent on MSRs etc.)

It seems we have already using `IntrInaccessibleMemOnly` + `IntrWillReturn` for constrained intrinsics https://github.com/llvm/llvm-project/blame/main/llvm/include/llvm/IR/Intrinsics.td#L764
For other X86 instrinsics, it should be not a problem for those embedded rounding control ones. But maybe we need to take care of a few legacy rounding intrinsics, e.g., https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/IR/IntrinsicsX86.td#L680-L691

@nikic IIUC, intrinsics without `IntrNoMem` don't need such change, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136939/new/

https://reviews.llvm.org/D136939