[PATCH] D136939: [X86] Use default attributes for intrinsics

Fri Oct 28 05:05:02 PDT 2022

nikic added a comment.

In D136939#3891529 <https://reviews.llvm.org/D136939#3891529>, @RKSimon wrote:

> In principal I think this patch is fine, do we have any thorough documentation on these attribute kinds?

These attributes are documented at https://llvm.org/docs/LangRef.html#function-attributes, with the exception of `nocallback`, which only has a pending patch at https://reviews.llvm.org/D131628. But I don't think callbacks are relevant for any of these intrinsics.

> I just want to ensure we're not going to have a problem with a few cases (e.g. the round intrinsics which can be dependent on MSRs etc.)

This shouldn't be a problem for the newly added attributes, but if you actually want to model that dependence, then the existing intrinsic definitions for these are incorrect (they cannot be IntrNoMem and need to read InaccessibleMemOnly instead, and intrinsics that modify MSRs need to write InaccessibleMemOnly, basically).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136939/new/

https://reviews.llvm.org/D136939