[PATCH] D136932: [Coroutines] Use default attributes for some coro intrinsics

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added a comment.

Thanks for doing this! I'll try to look at the other intrinsics. For this patch, coro.id looks OK to be marked as Default. But llvm.coro.subfn.addr can't be marked as `nofree` and I am not sure if it good to marked as `nosync`. Since `coro.subfn.addr` comes from either`coro.destroy(Frame*)` or `coro.resume(Frame*)`. And `destroy(Frame*)` is clearly not good for `nofree`. And we can think ``coro.resume(Frame*)`` is general call to any function (if we don't apply IPA). So it looks not good to mark it as `nosync` if I don't misunderstand `nosync`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136932/new/

https://reviews.llvm.org/D136932