[PATCH] D136342: [AArch64][SME] Set fn attributes correctly on __arm_tpidr2_save call.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/SMEABIPass.cpp:68
   auto Attrs =
-      AttributeList::get(M->getContext(), 0, {"aarch64_pstate_sm_compatible"});
   FunctionCallee Callee =
----------------
aemerson wrote:
> No objections to the patch but I'm a bit confused why this didn't work? Seems like a footgun to me.
I was similarly surprised. Perhaps there is some subtle difference that by adding it with the above interface, the attribute was somehow not a //function// attribute?
But then I don't know what kind of attribute it would be, or what the attribute applies to, given that it's still attached to a function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136342/new/

https://reviews.llvm.org/D136342