[PATCH] D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Core/LVSupport.h:172
+                "ValueType must be a pointer.");
+  using LVSecondMapType = std::map<SecondKeyType, ValueType>;
+  using LVFirstMapType = std::map<FirstKeyType, LVSecondMapType *>;
----------------
vitalybuka wrote:
> This code can be improved according to https://llvm.org/docs/ProgrammersManual.html#picking-the-right-data-structure-for-a-task
Thanks for the link. Added to the list of improvements.
The list will be added as 'README.txt' in `llvm\tools\llvm-debuginfo-analyzer`


================
Comment at: llvm/lib/DebugInfo/LogicalView/Readers/LVBinaryReader.cpp:383
+  LVAddress FirstAddress = Address;
+  LVLines *Instructions = new LVLines();
+
----------------
vitalybuka wrote:
> Why this code does not use unique_ptr<> ?
The memory management issue has been already discussed in the reviews and it would be addressed once the series of patches are landed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125783/new/

https://reviews.llvm.org/D125783