[PATCH] D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 27 21:45:59 PDT 2022
vitalybuka added inline comments.
================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Core/LVSupport.h:172
+ "ValueType must be a pointer.");
+ using LVSecondMapType = std::map<SecondKeyType, ValueType>;
+ using LVFirstMapType = std::map<FirstKeyType, LVSecondMapType *>;
----------------
This code can be improved according to https://llvm.org/docs/ProgrammersManual.html#picking-the-right-data-structure-for-a-task
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125783/new/
https://reviews.llvm.org/D125783
More information about the llvm-commits
mailing list