[PATCH] D136742: [llvm][LoongArch] Improve the "out of range" error information reported by `adjustFixupValue`

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 19:37:38 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchAsmBackend.cpp:82
+                                  MCContext &Ctx) {
+  Ctx.reportError(Fixup.getLoc(), "fixup value out of range [" +
+                                      Twine(llvm::minIntN(N)) + ", " +
----------------
The function just uses the Location, so a `SMLoc` parameter is more appropriate.
`MCContext` is usually added as the first parameter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136742/new/

https://reviews.llvm.org/D136742



More information about the llvm-commits mailing list