[PATCH] D136672: [ExpandMemCmp][AArch64] Add a new option PreferCmpToExpand in inMemCmpExpansionOptions and enable on AArch64

Thu Oct 27 18:11:31 PDT 2022

bcl5980 added a comment.

In D136672#3882041 <https://reviews.llvm.org/D136672#3882041>, @dmgreen wrote:

> Is this the same as https://reviews.llvm.org/D136244? Looks like there are two tickets for the same issue.
>
> They both solve it differently. D136244 <https://reviews.llvm.org/D136244> looks like it is more general - handling more cases then just bcmp. But this might optimize larger bcmp's? I think I would expect them to become a series of `cmp;ccmp;ccmp;ccmp` when optimized properly though.

I have rebase to the code already include D136244 <https://reviews.llvm.org/D136244>. These two tickets looks the same but it looks D136244 <https://reviews.llvm.org/D136244> can't fix the original case bcmp 3bytes. 
And not only AArch64, maybe this change also help some potential platform.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136672/new/

https://reviews.llvm.org/D136672