[PATCH] D136759: [AArch64][SVE2] Add the SVE2.1 while & pext predicate pair instructions

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 17:09:37 PDT 2022


paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64RegisterInfo.td:1000
+class PPRVectorListMul<int ElementWidth, int NumRegs> : PPRVectorList<ElementWidth, NumRegs> {
+  let Name = "SMEPredicateListMul" # NumRegs # "x" # ElementWidth;
+  let DiagnosticType = "Invalid" # Name;
----------------
`SVEPredicateListMul`


================
Comment at: llvm/lib/Target/AArch64/AArch64RegisterInfo.td:1009
+    DecoderMethod = "DecodePPR2Mul2RegisterClass" in {
+  def PP_b_mul : RegisterOperand<PPR2Mul2, "printTypedVectorList<0,'b'>"> {
+    let ParserMatchClass = PPRVectorListMul<8, 2>;
----------------
Should this be `PP_b_mul_r` to match the style used by `ZZ_b_mul_r`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136759/new/

https://reviews.llvm.org/D136759



More information about the llvm-commits mailing list