[PATCH] D135108: [llvm-driver] Fix clang -fno-integrated-cc1 when invoked from the llvm driver

Thu Oct 27 15:47:05 PDT 2022

abrachet marked an inline comment as done.
abrachet added a comment.

In D135108#3880245 <https://reviews.llvm.org/D135108#3880245>, @dblaikie wrote:

> naive question, but... what if the llvm-driver special cased `-cc1` as a tool? & then clang wouldn't have to do anything special?

Not a naive question at all. I had actually thought about this option too and listed it as one in this patch when it was a WIP, ultimately we thought that maybe it was too hacky, though so too is this patch. I've created D136895 <https://reviews.llvm.org/D136895> so that we can compare and contrast.

It's certainly a lot cleaner to just touch the llvm-driver binary and it's nice to not have to touch clang's Job handling. What do folks think?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135108/new/

https://reviews.llvm.org/D135108