[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

Ben Langmuir via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 14:41:44 PDT 2022


benlangmuir added inline comments.


================
Comment at: llvm/lib/MC/MCContext.cpp:62
 
-static cl::opt<char*>
+static cl::opt<std::string>
 AsSecureLogFileName("as-secure-log-file-name",
----------------
Interestingly, `opt<char*>` doesn't have a parser; this code only worked with the default value before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136888/new/

https://reviews.llvm.org/D136888



More information about the llvm-commits mailing list