[PATCH] D136871: [SelectionDAG] remove stale check assuming INLINEASM_BR is terminator

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 12:43:35 PDT 2022


nickdesaulniers added a comment.

@craig.topper mentions on discord:

> A TokenFactor collects multiple chains into a single chain. Chains are used to maintain order of things that don't have a natural data dependency. 
> Previously the inlineasm_br chain was dependent on the copy chains so it had to occur after them. Now they are considered independent.

Perhaps then the best way forward here is to simply adapt the existing comment that is still stale? Somehow?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136871/new/

https://reviews.llvm.org/D136871



More information about the llvm-commits mailing list