[PATCH] D136853: [OpenMP][OMPIRBuilder] Migrate createOffloadEntriesAndInfoMetadata from clang to OpenMPIRBuilder

[Jan Sjödin via Phabricator via llvm-commits]

jsjodin added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1101
+                          uint64_t Size, int32_t Flags,
+                          GlobalValue::LinkageTypes);
+
----------------
jdoerfert wrote:
> IsGPU is not great. If anything, let's call it "IsTargetCodegen" or similar. Also elsewhere. As this clashes with the special handling of "host offloading", I would suggest to then rename `IsDevice` to `IsEmbedded` or something. This should work for non-GPUs and also the "IsDevice" flag is misnamed as the host offloading is also targeting a device. 
> IsGPU is not great. If anything, let's call it "IsTargetCodegen" or similar. Also elsewhere. As this clashes with the special handling of "host offloading", I would suggest to then rename `IsDevice` to `IsEmbedded` or something. This should work for non-GPUs and also the "IsDevice" flag is misnamed as the host offloading is also targeting a device. 

Yes, I was a bit confused about the naming, so I opted to use the names that the clang options indicate. I will make the changes you suggested and hopefully that will be cleaner.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136853/new/

https://reviews.llvm.org/D136853