[PATCH] D136377: [mlir][MemRefToLLVM] Reuse existing subview lowering

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Thanks @ftynse and @nicolasvasilache  for your inputs. I feel we've reached an agreement (and an understanding on my end!): we'll use a two steps approach, first `expand-memref-ops`, second we do the actual `memref-to-llvm`.

@ftynse, for communicating this new requirement, should I just send a PSA on MLIR discourse, or you have something else in mind?

> The user is expected to run expand-math or convert-math-to-libm in their pass pipeline or otherwise get rid of those operations before calling convert-math-to-llvm. So I guess we can expect users to call expand-memref-ops, we just have to broadcast this requirement on the communication channels.

Sounds like a plan. I didn't realize it was okay to have dotted lines like that. I was looking for a working out-of-the-box solution.

Unless I miss something, this matches what Nicolas is suggesting in #1:

> 1. avoid populating the world in this pass and I would update the test to run mlir-opt --expand-memref-ops --affine-to-std --arith-to-llvm --memref-to-llvm

I'll keep a separate test for the full convert MemRef to LLVM "pipeline".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136377/new/

https://reviews.llvm.org/D136377