[PATCH] D136777: llvm::zip should not require assignment operator

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 07:57:38 PDT 2022


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

I've got mixed feelings - the mechanics of the change seem fine, but iterator requirements include copy assignability and copy constructibility - so whatever iterator you're going to use with this feature isn't implementing the iterator requirements and probably should be fixed? I guess the C++20 iterator concepts are a bit more flexible and may include this situation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136777/new/

https://reviews.llvm.org/D136777



More information about the llvm-commits mailing list