[PATCH] D136829: [SDAG] Fix v1i8 -> 1x i32 handling in getCopyToPartsVector

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 07:47:53 PDT 2022


Pierre-vh added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/dagcombine-v1i8-extractvecelt-crash.ll:10
+;
+;   t4: i32 = extract_vector_elt t10, Constant:i32<0>
+;
----------------
arsenm wrote:
> What exactly broke? Technically the return type is allowed to be a wider element than the original source vector (don't think trunc is legal though)
Ah then maybe the right change is to fix that place where trunc is used directly instead of getAnyExtOrTrunc?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136829/new/

https://reviews.llvm.org/D136829



More information about the llvm-commits mailing list