[PATCH] D123394: [CodeGen] Late cleanup of redundant address/immediate definitions.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 07:04:03 PDT 2022


RKSimon added inline comments.


================
Comment at: llvm/include/llvm/InitializePasses.h:277
 void initializeMachineCopyPropagationPass(PassRegistry&);
+void initializeRedundantImmLoadsCleanupPass(PassRegistry&);
 void initializeMachineCycleInfoPrinterPassPass(PassRegistry &);
----------------
jonpa wrote:
> RKSimon wrote:
> > This looks like it should be sorted?
> yes... Should the pass maybe better be named something with Machine... to make it clear that it is a late CodeGen pass? Maybe MachineImmLoadsCleanupPass or something?
SGTM - no strong preference tbh


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123394/new/

https://reviews.llvm.org/D123394



More information about the llvm-commits mailing list