[PATCH] D125783: [llvm-debuginfo-analyzer] 08 - ELF Reader

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 05:48:46 PDT 2022


thakis added inline comments.


================
Comment at: llvm/unittests/DebugInfo/LogicalView/CMakeLists.txt:9
 
-add_llvm_unittest(DebugInfoLogicalViewTests
+add_llvm_unittest_with_input_files(DebugInfoLogicalViewTests
   CommandLineOptionsTest.cpp
----------------
See:

```
# Use for test binaries that call llvm::getInputFileDirectory(). Use of this
# is discouraged.
function(add_unittest_with_input_files test_suite test_name)
```

Any chance you could write this test without needing getInputFileDirectory()?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125783/new/

https://reviews.llvm.org/D125783



More information about the llvm-commits mailing list