[PATCH] D136525: [M68k] Add codegen pattern for atomic load / store

Sheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 04:34:08 PDT 2022


0x59616e marked an inline comment as done.
0x59616e added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kTargetMachine.cpp:161
 
+void M68kPassConfig::addIRPasses() { addPass(createAtomicExpandPass()); }
+
----------------
RKSimon wrote:
> 0x59616e wrote:
> > RKSimon wrote:
> > > Also - do we need to add an pipeline.ll test file?
> > What is pipeline.ll ?
> https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/AMDGPU/llc-pipeline.ll
> https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/ARM/O3-pipeline.ll
> https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/X86/opt-pipeline.ll
> 
> Different backends do it differently, but basically its a test file that checks what passes have been run at all/some opt levels
Thanks. This looks interesting. As far as I'm concerned, there is no reason not to add this one in M68k.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136525/new/

https://reviews.llvm.org/D136525



More information about the llvm-commits mailing list