[PATCH] D136483: [mlir][MemRefToLLVM] Reuse existing lowering for collaspe/expand_shape

[Alex Zinenko via Phabricator via llvm-commits]

ftynse added a comment.

So if I understand correctly, we are now emitting more arithmetics that we are unable to simplify at the MLIR level. This sounds concerning and seem to defy the purpose of using affine maps, which should be the easy-to-compose closed-form expressions. Do we expect LLVM's CSE to simplify this? Is there any indication of this actually happening or not? (In one my previous projects, we've seen a performance improvement attributable to better/simpler address generation via memrefs, which we may now undo...)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136483/new/

https://reviews.llvm.org/D136483