[PATCH] D136813: [AMDGPU] Add pseudo wavemode to optimize strict_wqm

[Carl Ritson via Phabricator via llvm-commits]

critson added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstructions.td:193-194
+def ENTER_PSEUDO_WM : SPseudoInstSI <(outs), (ins)> {
+  let Uses = [EXEC];
+  let Defs = [EXEC];
+  let hasSideEffects = 0;
----------------
foad wrote:
> Does it need the implicit use and def?
Probably not, but I wasn't sure if the EXEC modification was being used to avoid something else happening in the backend passes.

Technically all the EXIT_ types should be marked as implict def of EXEC too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136813/new/

https://reviews.llvm.org/D136813