[PATCH] D135887: [XOCFF] llvvm-readobj support display symbol table of loader section of xcoff object file.

Thu Oct 27 01:32:28 PDT 2022

jhenderson added a comment.

In D135887#3885526 <https://reviews.llvm.org/D135887#3885526>, @DiggerLin wrote:

> gentle ping @jhenderson and @Esme .

I was waiting on @Esme to respond to your latest comment, as it's a bit outside where I feel comfortable to make an informed decision.

It does sound to me like dynamic symbols/loader section symbols are functionally the same thing (and also dynamic/loader section relocations). However, I also get the point that the terminology is different.

Re. the documentation: it's ELF-specific, because no other format supported the option yet. That's not a reason not to move the option out of the ELF-specific options section. I note that in the Options.td file, `--dyn-syms` is already not in the ELF-specific area, so perhaps somebody has implemented it for another file format but forgot to update the docs? To address the different terminology point, how about the code be moved into printDynamicSymbols and then make `--loader-section-symbols` an alias of `--dyn-syms`. A similar approach could be adopted for the --loader-section-relocations` option, which would be similar to priting dynamic relocations for ELF, I expect.

================
Comment at: llvm/docs/CommandGuide/llvm-readobj.rst:341

+.. option:: --loader-section-symbol
+
----------------
Make this a plural name, as there's more than one symbol (typically). (The same will go for the relocation option in the next patch).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135887/new/

https://reviews.llvm.org/D135887