[PATCH] D136689: [AArch64][SVE2] Add the SVE2.1 extract-and-narrow instructions

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 27 00:35:50 PDT 2022


david-arm marked an inline comment as done.
david-arm added inline comments.


================
Comment at: llvm/test/MC/AArch64/SVE2p1/sqcvtn-diagnostics.s:7
+sqcvtn z0.h, {z0.s-z2.s}
+// CHECK: [[@LINE-1]]:{{[0-9]+}}: error: invalid operand for instruction
+// CHECK-NEXT: sqcvtn z0.h, {z0.s-z2.s}
----------------
paulwalker-arm wrote:
> Just an observation but it seems preferable to get the same nice error message as we do for the `{z1.s-z2.s}` case.
If I get chance I can try to take a look at this. I suspect it's probably due to non-matching suffixes for the single vector and vector list. We probably need to change how we deal with diagnostics for ZZ_s_mul_r operands.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136689/new/

https://reviews.llvm.org/D136689



More information about the llvm-commits mailing list