[PATCH] D136415: [LSR] Check if terminating value is safe to expand before transformation

[Jiejie Rong via Phabricator via llvm-commits]

JojoR added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:6825
       // TermValue = Start + Stride * (BackedgeCount + 1)
       const SCEV *TermValueS = SE.getAddExpr(
           AddRec->getOperand(0),
----------------
eopXD wrote:
> JojoR wrote:
> > The patch looks good to me,
> > but the implementation is redundant with here ?
> > it should merge into one ?
> Sorry, may you explain more on the redundancy you see here.
Looks only one expression, ignore this comment.
my original consideration is that put same action/checker into one place, it's ok also here :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136415/new/

https://reviews.llvm.org/D136415