[PATCH] D136415: [LSR] Check if terminating value is safe to expand before transformation
Yueh-Ting (eop) Chen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 27 00:02:14 PDT 2022
eopXD added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:6825
// TermValue = Start + Stride * (BackedgeCount + 1)
const SCEV *TermValueS = SE.getAddExpr(
AddRec->getOperand(0),
----------------
JojoR wrote:
> The patch looks good to me,
> but the implementation is redundant with here ?
> it should merge into one ?
Sorry, may you explain more on the redundancy you see here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136415/new/
https://reviews.llvm.org/D136415
More information about the llvm-commits
mailing list