[PATCH] D127831: BasicBlockUtils: Add a new way for CreateControlFlowHub()

[Sameer Sahasrabuddhe via Phabricator via llvm-commits]

sameerds accepted this revision.
sameerds added a comment.
This revision is now accepted and ready to land.

LGTM, with a minor issue in the option name and description.



================
Comment at: llvm/lib/Transforms/Utils/BasicBlockUtils.cpp:60-64
+static cl::opt<unsigned> MaxBooleansEachUnify(
+    "max-booleans-each-unify", cl::init(32), cl::Hidden,
+    cl::desc("Set the maximum number of outgoing blocks for when a boolean "
+             "value is used to record the exiting block."));
+
----------------
The option name and its description does not really say which utility it's meant for in this file. I would suggest a name such as "MaxBooleansInControlFlowHub" along with a mention of the control flow hub in the description.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127831/new/

https://reviews.llvm.org/D127831