[PATCH] D136793: [AArch64][GlobalISel] Add some minor post-selection optimizations.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 26 23:04:40 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64PostSelectOptimize.cpp:108
+
+  if (!Src.isVirtual() || !Dst.isVirtual())
+    return false;
----------------
aemerson wrote:
> paquette wrote:
> > `isPhysical`?
> Registers can be either physical, virtual or stack slots apparently, so it's better to use `isVirtual()`.
I'm pretty sure the stack slot case only happens transiently in regalloc 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136793/new/

https://reviews.llvm.org/D136793



More information about the llvm-commits mailing list